From 457efa8136ea12d3bcedf9146e3cd415448628e5 Mon Sep 17 00:00:00 2001 From: Ganesh Nalawade Date: Sat, 4 May 2019 07:23:12 -0400 Subject: [PATCH] Fix invalid src option return response for network config modules (#56076) * Add changed key in faliure case to maintain backward compatibility (cherry picked from commit 1a66121f0319793f05e969b94b4642e6475e6462) --- changelogs/fragments/networkos_config_src_option_fix.yaml | 2 ++ lib/ansible/plugins/action/network.py | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/networkos_config_src_option_fix.yaml diff --git a/changelogs/fragments/networkos_config_src_option_fix.yaml b/changelogs/fragments/networkos_config_src_option_fix.yaml new file mode 100644 index 00000000000..f73c4c265cf --- /dev/null +++ b/changelogs/fragments/networkos_config_src_option_fix.yaml @@ -0,0 +1,2 @@ +bugfixes: + - Fix invalid src option return response for network config modules (https://github.com/ansible/ansible/pull/56076) diff --git a/lib/ansible/plugins/action/network.py b/lib/ansible/plugins/action/network.py index d7b8a61f425..277dc708954 100644 --- a/lib/ansible/plugins/action/network.py +++ b/lib/ansible/plugins/action/network.py @@ -40,7 +40,10 @@ class ActionModule(_ActionModule): def run(self, task_vars=None): config_module = hasattr(self, '_config_module') and self._config_module if config_module and self._task.args.get('src'): - self._handle_src_option() + try: + self._handle_src_option() + except AnsibleError as e: + return {'failed': True, 'msg': e.message, 'changed': False} result = super(ActionModule, self).run(task_vars=task_vars)