From 4553ec5cc5c0621a2cf519c82f20d72c1219ece3 Mon Sep 17 00:00:00 2001 From: Will Thames Date: Wed, 27 Sep 2017 00:25:49 +1000 Subject: [PATCH] [cloud] Ensure target group ARNs are passed as a list in `ec2_asg` (#30905) While sets are useful for comparing whether target groups need modifying, the AWS API expects a list or tuple, not a set --- lib/ansible/modules/cloud/amazon/ec2_asg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/cloud/amazon/ec2_asg.py b/lib/ansible/modules/cloud/amazon/ec2_asg.py index 78e0c3f15f0..69b51d196c0 100644 --- a/lib/ansible/modules/cloud/amazon/ec2_asg.py +++ b/lib/ansible/modules/cloud/amazon/ec2_asg.py @@ -943,13 +943,13 @@ def create_autoscaling_group(connection, module): tgs_to_detach = has_tgs.difference(wanted_tgs) if tgs_to_detach: changed = True - detach_lb_target_groups(connection, group_name, tgs_to_detach) + detach_lb_target_groups(connection, group_name, list(tgs_to_detach)) if wanted_tgs.issuperset(has_tgs): # if has contains less than wanted, then we need to add some tgs_to_attach = wanted_tgs.difference(has_tgs) if tgs_to_attach: changed = True - attach_lb_target_groups(connection, group_name, tgs_to_attach) + attach_lb_target_groups(connection, group_name, list(tgs_to_attach)) # check for attributes that aren't required for updating an existing ASG desired_capacity = desired_capacity if desired_capacity is not None else as_group['DesiredCapacity']