From 434643000343f3d560216ff7edfb03a3e1621e67 Mon Sep 17 00:00:00 2001 From: Matt Clay Date: Fri, 30 Aug 2024 16:46:45 -0700 Subject: [PATCH] ansible-test - Reduce scope of empty-init test (#83878) --- changelogs/fragments/ansible-test-sanity-empty-init.yml | 2 ++ .../_util/controller/sanity/code-smell/empty-init.json | 2 -- test/sanity/ignore.txt | 3 --- 3 files changed, 2 insertions(+), 5 deletions(-) create mode 100644 changelogs/fragments/ansible-test-sanity-empty-init.yml diff --git a/changelogs/fragments/ansible-test-sanity-empty-init.yml b/changelogs/fragments/ansible-test-sanity-empty-init.yml new file mode 100644 index 00000000000..0ba349bc773 --- /dev/null +++ b/changelogs/fragments/ansible-test-sanity-empty-init.yml @@ -0,0 +1,2 @@ +minor_changes: + - ansible-test - The ``empty-init`` sanity test no longer applies to ``module_utils`` packages. diff --git a/test/lib/ansible_test/_util/controller/sanity/code-smell/empty-init.json b/test/lib/ansible_test/_util/controller/sanity/code-smell/empty-init.json index 9835f9b6c88..eb13314264e 100644 --- a/test/lib/ansible_test/_util/controller/sanity/code-smell/empty-init.json +++ b/test/lib/ansible_test/_util/controller/sanity/code-smell/empty-init.json @@ -1,9 +1,7 @@ { "prefixes": [ "lib/ansible/modules/", - "lib/ansible/module_utils/", "plugins/modules/", - "plugins/module_utils/", "test/units/", "tests/unit/" ], diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index 9a1328eff28..be3d59f7cd9 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -39,8 +39,6 @@ lib/ansible/module_utils/compat/selinux.py import-3.12!skip # pass/fail depends lib/ansible/module_utils/compat/selinux.py import-3.13!skip # pass/fail depends on presence of libselinux.so lib/ansible/module_utils/compat/selinux.py pylint:unidiomatic-typecheck lib/ansible/module_utils/distro/_distro.py no-assert -lib/ansible/module_utils/distro/__init__.py empty-init # breaks namespacing, bundled, do not override -lib/ansible/module_utils/facts/__init__.py empty-init # breaks namespacing, deprecate and eventually remove lib/ansible/module_utils/powershell/Ansible.ModuleUtils.ArgvParser.psm1 pslint:PSUseApprovedVerbs lib/ansible/module_utils/powershell/Ansible.ModuleUtils.CommandUtil.psm1 pslint:PSProvideCommentHelp # need to agree on best format for comment location lib/ansible/module_utils/powershell/Ansible.ModuleUtils.CommandUtil.psm1 pslint:PSUseApprovedVerbs @@ -50,7 +48,6 @@ lib/ansible/module_utils/powershell/Ansible.ModuleUtils.Legacy.psm1 pslint:PSCus lib/ansible/module_utils/powershell/Ansible.ModuleUtils.Legacy.psm1 pslint:PSUseApprovedVerbs lib/ansible/module_utils/powershell/Ansible.ModuleUtils.LinkUtil.psm1 pslint:PSUseApprovedVerbs lib/ansible/module_utils/pycompat24.py no-get-exception -lib/ansible/module_utils/six/__init__.py empty-init # breaks namespacing, bundled, do not override lib/ansible/module_utils/six/__init__.py pylint:self-assigning-variable lib/ansible/module_utils/six/__init__.py pylint:trailing-comma-tuple lib/ansible/module_utils/six/__init__.py pylint:unidiomatic-typecheck