Ensure `allow_duplicates: true` enables to run single role multiple times (#64902) (#65063)

* Ensure `allow_duplicates: true` enables to run single role multiple times(#64902)

* Changed return value in `_load_roles` . Fixes #64902

* Add changelog fragment

* Add an integration test for the issue

* Fix changelog generation error and integration test.

* Fix yaml syntax error in changelog fragment

* Fix typo in a changelog fragment of #64902

(cherry picked from commit daecbb9bf0)
(cherry picked from commit 33094e6c8e)

changelogs/fragments/64902-fix-allow-duplicates-in-single-role.yml

@@ -0,0 +1,4 @@
+---
+bugfixes:
+  - "roles - Ensure that ``allow_duplicates: true`` enables to run single
+    role multiple times (https://github.com/ansible/ansible/issues/64902)"

lib/ansible/playbook/play.py

@@ -199,11 +199,9 @@ class Play(Base, Taggable, Become, CollectionSearch):
         for ri in role_includes:
             roles.append(Role.load(ri, play=self))
 
-        return self._extend_value(
-            self.roles,
-            roles,
-            prepend=True
-        )
+        self.roles[:0] = roles
+
+        return self.roles
 
     def _load_vars_prompt(self, attr, ds):
         new_ds = preprocess_vars(ds)

test/integration/targets/include_import/roles/dup_allowed_role/meta/main.yml

@@ -0,0 +1,2 @@
+---
+allow_duplicates: true

test/integration/targets/include_import/roles/dup_allowed_role/tasks/main.yml

@@ -0,0 +1,3 @@
+---
+- debug:
+    msg: "Tasks file inside role"

test/integration/targets/include_import/runme.sh

@@ -104,3 +104,7 @@ ansible-playbook test_loop_var_bleed.yaml "$@"
 
 # https://github.com/ansible/ansible/issues/56580
 ansible-playbook valid_include_keywords/playbook.yml "$@"
+
+# https://github.com/ansible/ansible/issues/64902
+ansible-playbook tasks/test_allow_single_role_dup.yml 2>&1 | tee test_allow_single_role_dup.out
+test "$(grep -c 'ok=3' test_allow_single_role_dup.out)" = 1

test/integration/targets/include_import/tasks/test_allow_single_role_dup.yml

@@ -0,0 +1,8 @@
+---
+- name: test for allow_duplicates with single role
+  hosts: localhost
+  gather_facts: false
+  roles:
+    - dup_allowed_role
+    - dup_allowed_role
+    - dup_allowed_role