diff --git a/command b/command index c3dc4cdb4d9..13dbb089f63 100644 --- a/command +++ b/command @@ -99,7 +99,7 @@ def main(): args = shlex.split(args) startd = datetime.datetime.now() - rc, out, err = module.run_command(args, shell=shell, executable=executable) + rc, out, err = module.run_command(args, executable=executable) endd = datetime.datetime.now() delta = endd - startd diff --git a/facter b/facter index 9f6523e7fe9..9bb807dcff1 100644 --- a/facter +++ b/facter @@ -44,7 +44,7 @@ def main(): ) cmd = ["/usr/bin/env", "facter", "--json"] - rc, out, err = module.run_command(cmd, fail_on_rc_non_zero=True) + rc, out, err = module.run_command(cmd, check_rc=True) module.exit_json(**json.loads(out)) # this is magic, see lib/ansible/module_common.py diff --git a/git b/git index b63b3f94d7a..ad3da4fce16 100644 --- a/git +++ b/git @@ -81,7 +81,7 @@ def clone(module, repo, dest, remote): pass os.chdir(dest_dirname) return module.run_command("git clone -o %s %s %s" % (remote, repo, dest), - fail_on_rc_non_zero=True) + check_rc=True) def has_local_mods(dest): os.chdir(dest) @@ -99,7 +99,7 @@ def reset(module,dest,force): os.chdir(dest) if not force and has_local_mods(dest): module.fail_json(msg="Local modifications exist in repository (force=no).") - return module.run_command("git reset --hard HEAD", fail_on_rc_non_zero=True) + return module.run_command("git reset --hard HEAD", check_rc=True) def get_branches(module, dest): os.chdir(dest) @@ -210,7 +210,7 @@ def switch_version(module, dest, remote, version): if rc != 0: module.fail_json(msg="Failed to checkout branch %s" % branch) cmd = "git reset --hard %s" % remote - return module.run_command(cmd, fail_on_rc_non_zero=True) + return module.run_command(cmd, check_rc=True) # =========================================== diff --git a/ohai b/ohai index fc5538d2356..fd048a7df2b 100644 --- a/ohai +++ b/ohai @@ -43,7 +43,7 @@ def main(): argument_spec = dict() ) cmd = ["/usr/bin/env", "ohai"] - rc, out, err = module.run_command(cmd, fail_on_rc_non_zero=True) + rc, out, err = module.run_command(cmd, check_rc=True) module.exit_json(**json.loads(out)) # this is magic, see lib/ansible/module_common.py diff --git a/subversion b/subversion index 336ab2746c2..c8cd5198b67 100644 --- a/subversion +++ b/subversion @@ -85,7 +85,7 @@ class Subversion(object): if self.password: bits.append("--password '%s'" % self.password) bits.append(args) - rc, out, err = self.module.run_command(' '.join(bits), fail_on_rc_non_zero=True) + rc, out, err = self.module.run_command(' '.join(bits), check_rc=True) return out.splitlines() def checkout(self): diff --git a/supervisorctl b/supervisorctl index 89c2e476b19..0882a3a3dde 100644 --- a/supervisorctl +++ b/supervisorctl @@ -63,7 +63,7 @@ def main(): if state == 'present': if not present: - module.run_command('%s reread' % SUPERVISORCTL, fail_on_rc_non_zero=True) + module.run_command('%s reread' % SUPERVISORCTL, check_rc=True) rc, out, err = module.run_command('%s add %s' % (SUPERVISORCTL, name)) if '%s: added process group' % name in out: