ufw fails asking for a direction for rules without an interface specified [#2758] (#2759)

8 years ago · 3e31eaf419
parent 692fb45e26
commit 3e31eaf419
1 changed files with 1 additions and 1 deletions
--- a/lib/ansible/modules/extras/system/ufw.py
+++ b/lib/ansible/modules/extras/system/ufw.py
@ -228,7 +228,7 @@ def main():
    if len(commands) < 1:
        module.fail_json(msg="Not any of the command arguments %s given" % commands)

-    if('interface' in params and params['direction'] is None):
+    if(params['interface'] is not None and params['direction'] is None):
      module.fail_json(msg="Direction must be specified when creating a rule on an interface")

    # Ensure ufw is available