From 3b60cb3847c580454f69c5e812719ecf03aa38b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Moser?= Date: Fri, 18 Nov 2016 18:12:57 +0100 Subject: [PATCH] cloudstack: cs_snapshot_policy: ignore intervaltype in has_changed (#3499) Fixes ValueError: invalid literal for int() with base 10: 'daily' --- .../extras/cloud/cloudstack/cs_snapshot_policy.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/ansible/modules/extras/cloud/cloudstack/cs_snapshot_policy.py b/lib/ansible/modules/extras/cloud/cloudstack/cs_snapshot_policy.py index ce8b2344f36..a3a76ba4c10 100644 --- a/lib/ansible/modules/extras/cloud/cloudstack/cs_snapshot_policy.py +++ b/lib/ansible/modules/extras/cloud/cloudstack/cs_snapshot_policy.py @@ -230,13 +230,14 @@ class AnsibleCloudStackSnapshotPolicy(AnsibleCloudStack): policy = self.get_snapshot_policy() args = { + 'id': policy.get('id') if policy else None, 'intervaltype': self.module.params.get('interval_type'), - 'schedule': self.module.params.get('schedule'), - 'maxsnaps': self.module.params.get('max_snaps'), - 'timezone': self.module.params.get('time_zone'), - 'volumeid': self.get_volume(key='id') + 'schedule': self.module.params.get('schedule'), + 'maxsnaps': self.module.params.get('max_snaps'), + 'timezone': self.module.params.get('time_zone'), + 'volumeid': self.get_volume(key='id') } - if not policy or (policy and self.has_changed(policy, args)): + if not policy or (policy and self.has_changed(policy, args, only_keys=['schedule', 'maxsnaps', 'timezone'])): self.result['changed'] = True if not self.module.check_mode: res = self.cs.createSnapshotPolicy(**args)