add info about plugin name when ignoring abstract errors (#78465)

* add info about plugin name when ignoring abstract

  related to #78464

* added error to narrow down method
pull/78528/head
Brian Coca 3 years ago committed by GitHub
parent 99016653a2
commit 3a59cb25f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -0,0 +1,3 @@
bugfixes:
- plugin loader, now when skipping a plugin due to an abstract method error we provide that in 'verbose' mode instead of totally obscuring the error.
The current implementation assumed only the base classes would trigger this and failed to consider 'in development' plugins.

@ -873,8 +873,8 @@ class PluginLoader:
obj = instance
except TypeError as e:
if "abstract" in e.args[0]:
# Abstract Base Class. The found plugin file does not
# fully implement the defined interface.
# Abstract Base Class or incomplete plugin, don't load
display.v('Returning not found on "%s" as it has unimplemented abstract methods; %s' % (name, to_native(e)))
return get_with_context_result(None, plugin_load_context)
raise

Loading…
Cancel
Save