win_updates: Correctly report changes on success (2.7 backport) (#50225)

* win_updates: Correctly report changes on success * Add changelog fragment
7 years ago · 39af3b0b60
parent 05322334b0
commit 39af3b0b60
2 changed files with 8 additions and 1 deletions
--- a/changelogs/fragments/50185-win_updates-report-changes-correctly.yml
+++ b/changelogs/fragments/50185-win_updates-report-changes-correctly.yml
@ -0,0 +1,3 @@
+---
+bugfixes:
+- win_updates - Correctly report changes on success
--- a/lib/ansible/modules/windows/win_updates.ps1
+++ b/lib/ansible/modules/windows/win_updates.ps1
@ -346,7 +346,11 @@ $update_script_block = {
        $result.reboot_required = (New-Object -ComObject Microsoft.Update.SystemInfo).RebootRequired
        $result.installed_update_count = $update_success_count
        $result.failed_update_count = $update_fail_count
-        
+
+        if ($updates_success_count -gt 0) {
+            $result.changed = $true
+        }
+
        if ($update_fail_count -gt 0) {
            $result.failed = $true
            $result.msg = "Failed to install one or more updates"