diff --git a/changelogs/fragments/ansible-test-sanity-no-main-display.yml b/changelogs/fragments/ansible-test-sanity-no-main-display.yml new file mode 100644 index 00000000000..e59a72b29ae --- /dev/null +++ b/changelogs/fragments/ansible-test-sanity-no-main-display.yml @@ -0,0 +1,3 @@ +minor_changes: + - ansible-test - Removed the ``no-main-display`` sanity test. + The unwanted pattern is unlikely to occur, since the test has existed since Ansible 2.8. diff --git a/test/lib/ansible_test/_util/controller/sanity/code-smell/no-main-display.json b/test/lib/ansible_test/_util/controller/sanity/code-smell/no-main-display.json deleted file mode 100644 index ccee80a2f12..00000000000 --- a/test/lib/ansible_test/_util/controller/sanity/code-smell/no-main-display.json +++ /dev/null @@ -1,10 +0,0 @@ -{ - "extensions": [ - ".py" - ], - "prefixes": [ - "lib/ansible/", - "plugins/" - ], - "output": "path-line-column-message" -} diff --git a/test/lib/ansible_test/_util/controller/sanity/code-smell/no-main-display.py b/test/lib/ansible_test/_util/controller/sanity/code-smell/no-main-display.py deleted file mode 100644 index eb5987d9c3d..00000000000 --- a/test/lib/ansible_test/_util/controller/sanity/code-smell/no-main-display.py +++ /dev/null @@ -1,21 +0,0 @@ -"""Disallow importing display from __main__.""" -from __future__ import annotations - -import sys - -MAIN_DISPLAY_IMPORT = 'from __main__ import display' - - -def main(): - """Main entry point.""" - for path in sys.argv[1:] or sys.stdin.read().splitlines(): - with open(path, 'r', encoding='utf-8') as file: - for i, line in enumerate(file.readlines()): - if MAIN_DISPLAY_IMPORT in line: - lineno = i + 1 - colno = line.index(MAIN_DISPLAY_IMPORT) + 1 - print('%s:%d:%d: Display is a singleton, just import and instantiate' % (path, lineno, colno)) - - -if __name__ == '__main__': - main()