From 31a01305ba96588dc403ea2cc92677bae99aa9ee Mon Sep 17 00:00:00 2001 From: Chris Church Date: Fri, 10 Jul 2015 16:33:00 -0400 Subject: [PATCH] Set force=yes as the default, add force parameter to module docs. --- lib/ansible/modules/windows/win_get_url.ps1 | 2 +- lib/ansible/modules/windows/win_get_url.py | 22 +++++++++++++++++---- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/lib/ansible/modules/windows/win_get_url.ps1 b/lib/ansible/modules/windows/win_get_url.ps1 index 02f19b39360..46979c129f2 100644 --- a/lib/ansible/modules/windows/win_get_url.ps1 +++ b/lib/ansible/modules/windows/win_get_url.ps1 @@ -40,7 +40,7 @@ Else { Fail-Json $result "missing required argument: dest" } -$force = Get-Attr -obj $params -name "force" "no" | ConvertTo-Bool +$force = Get-Attr -obj $params -name "force" "yes" | ConvertTo-Bool If ($force -or -not (Test-Path $dest)) { $client = New-Object System.Net.WebClient diff --git a/lib/ansible/modules/windows/win_get_url.py b/lib/ansible/modules/windows/win_get_url.py index 585d3e2aa81..a34f23890b5 100644 --- a/lib/ansible/modules/windows/win_get_url.py +++ b/lib/ansible/modules/windows/win_get_url.py @@ -27,20 +27,28 @@ module: win_get_url version_added: "1.7" short_description: Fetches a file from a given URL description: - - Fetches a file from a URL and saves to locally + - Fetches a file from a URL and saves to locally options: url: description: - The full URL of a file to download required: true default: null - aliases: [] dest: description: - - The absolute path of the location to save the file at the URL. Be sure to include a filename and extension as appropriate. + - The absolute path of the location to save the file at the URL. Be sure + to include a filename and extension as appropriate. + required: true + default: null + force: + description: + - If C(yes), will always download the file. If C(no), will only + download the file if it does not exist or the remote file has been + modified more recently than the local file. + version_added: "2.0" required: false + choices: [ "yes", "no" ] default: yes - aliases: [] author: "Paul Durivage (@angstwad)" ''' @@ -54,4 +62,10 @@ $ ansible -i hosts -c winrm -m win_get_url -a "url=http://www.example.com/earthr win_get_url: url: 'http://www.example.com/earthrise.jpg' dest: 'C:\Users\RandomUser\earthrise.jpg' + +- name: Download earthrise.jpg to 'C:\Users\RandomUser\earthrise.jpg' only if modified + win_get_url: + url: 'http://www.example.com/earthrise.jpg' + dest: 'C:\Users\RandomUser\earthrise.jpg' + force: no '''