From 2fa8ee503cfe1dadb4ae7805884afd7e29efd878 Mon Sep 17 00:00:00 2001 From: Matt Clay Date: Fri, 3 Feb 2023 14:16:06 -0800 Subject: [PATCH] Clean up unused imports in modules (#79898) --- changelogs/fragments/unused-imports-modules.yml | 2 ++ lib/ansible/modules/apt.py | 1 - lib/ansible/modules/dnf.py | 2 +- lib/ansible/modules/expect.py | 2 +- lib/ansible/modules/pip.py | 1 - lib/ansible/modules/slurp.py | 1 - lib/ansible/modules/user.py | 2 -- lib/ansible/modules/yum.py | 1 - 8 files changed, 4 insertions(+), 8 deletions(-) create mode 100644 changelogs/fragments/unused-imports-modules.yml diff --git a/changelogs/fragments/unused-imports-modules.yml b/changelogs/fragments/unused-imports-modules.yml new file mode 100644 index 00000000000..b3e35f27bf7 --- /dev/null +++ b/changelogs/fragments/unused-imports-modules.yml @@ -0,0 +1,2 @@ +minor_changes: + - "Removed unused imports from the following modules: apt, dnf, expect, pip, slurp, user, yum" diff --git a/lib/ansible/modules/apt.py b/lib/ansible/modules/apt.py index b98a47a6f5e..2a214392c25 100644 --- a/lib/ansible/modules/apt.py +++ b/lib/ansible/modules/apt.py @@ -353,7 +353,6 @@ warnings.filterwarnings('ignore', "apt API not stable yet", FutureWarning) import datetime import fnmatch -import itertools import locale as locale_module import os import random diff --git a/lib/ansible/modules/dnf.py b/lib/ansible/modules/dnf.py index 8334ceff730..4357823981b 100644 --- a/lib/ansible/modules/dnf.py +++ b/lib/ansible/modules/dnf.py @@ -378,7 +378,7 @@ import sys from ansible.module_utils._text import to_native, to_text from ansible.module_utils.urls import fetch_file -from ansible.module_utils.six import PY2, text_type +from ansible.module_utils.six import text_type from ansible.module_utils.compat.version import LooseVersion from ansible.module_utils.basic import AnsibleModule diff --git a/lib/ansible/modules/expect.py b/lib/ansible/modules/expect.py index 99ffe9f263a..b8c9aa7ee47 100644 --- a/lib/ansible/modules/expect.py +++ b/lib/ansible/modules/expect.py @@ -119,7 +119,7 @@ except ImportError: HAS_PEXPECT = False from ansible.module_utils.basic import AnsibleModule, missing_required_lib -from ansible.module_utils._text import to_bytes, to_native, to_text +from ansible.module_utils._text import to_bytes, to_native def response_closure(module, question, responses): diff --git a/lib/ansible/modules/pip.py b/lib/ansible/modules/pip.py index 353c800a6e6..15c8c4420aa 100644 --- a/lib/ansible/modules/pip.py +++ b/lib/ansible/modules/pip.py @@ -271,7 +271,6 @@ import tempfile import operator import shlex import traceback -import types from ansible.module_utils.compat.version import LooseVersion diff --git a/lib/ansible/modules/slurp.py b/lib/ansible/modules/slurp.py index 55abfebf9f5..f04f3d7a7e5 100644 --- a/lib/ansible/modules/slurp.py +++ b/lib/ansible/modules/slurp.py @@ -84,7 +84,6 @@ source: import base64 import errno -import os from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.common.text.converters import to_native diff --git a/lib/ansible/modules/user.py b/lib/ansible/modules/user.py index 97873346e0e..022797a8499 100644 --- a/lib/ansible/modules/user.py +++ b/lib/ansible/modules/user.py @@ -442,9 +442,7 @@ uid: ''' -import ctypes import ctypes.util -import errno import grp import calendar import os diff --git a/lib/ansible/modules/yum.py b/lib/ansible/modules/yum.py index 6934ed6d094..cb48789d066 100644 --- a/lib/ansible/modules/yum.py +++ b/lib/ansible/modules/yum.py @@ -408,7 +408,6 @@ from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.common.locale import get_best_parsable_locale from ansible.module_utils.common.respawn import has_respawned, respawn_module from ansible.module_utils._text import to_native, to_text -from ansible.module_utils.urls import fetch_url from ansible.module_utils.yumdnf import YumDnf, yumdnf_argument_spec import errno