From 2e7dcf3317949de7ae412f77d9372dc2f12ce31f Mon Sep 17 00:00:00 2001 From: Toshio Kuratomi Date: Wed, 24 Jun 2015 06:51:00 -0700 Subject: [PATCH] Small cleanups. * Import url(lib|parse|lib2) if needed by the module rather than relying on module_utils.urls to do so. * Remove stdlib modules from requirements * Use the if __name__ conditional for invoking main() --- lib/ansible/modules/network/basics/get_url.py | 7 +++++-- lib/ansible/modules/packaging/os/rpm_key.py | 6 ++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/ansible/modules/network/basics/get_url.py b/lib/ansible/modules/network/basics/get_url.py index 074bf8bb484..f7ea5008cee 100644 --- a/lib/ansible/modules/network/basics/get_url.py +++ b/lib/ansible/modules/network/basics/get_url.py @@ -113,7 +113,7 @@ options: - all arguments accepted by the M(file) module also work here required: false # informational: requirements for nodes -requirements: [ urllib2, urlparse ] +requirements: [ ] author: "Jan-Piet Mens (@jpmens)" ''' @@ -125,6 +125,8 @@ EXAMPLES=''' get_url: url=http://example.com/path/file.conf dest=/etc/foo.conf sha256sum=b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c ''' +import urlparse + try: import hashlib HAS_HASHLIB=True @@ -315,4 +317,5 @@ def main(): # import module snippets from ansible.module_utils.basic import * from ansible.module_utils.urls import * -main() +if __name__ == '__main__': + main() diff --git a/lib/ansible/modules/packaging/os/rpm_key.py b/lib/ansible/modules/packaging/os/rpm_key.py index 1b38da3823b..d2d5e684015 100644 --- a/lib/ansible/modules/packaging/os/rpm_key.py +++ b/lib/ansible/modules/packaging/os/rpm_key.py @@ -60,9 +60,10 @@ EXAMPLES = ''' # Example action to ensure a key is not present in the db - rpm_key: state=absent key=DEADB33F ''' +import re import syslog import os.path -import re +import urllib2 import tempfile def is_pubkey(string): @@ -203,4 +204,5 @@ def main(): # import module snippets from ansible.module_utils.basic import * from ansible.module_utils.urls import * -main() +if __name__ == '__main__': + main()