From 2d90cbf78b8ba2c86fad62067f31c9e668c3890c Mon Sep 17 00:00:00 2001 From: James Cammarata Date: Tue, 28 Jul 2015 10:14:48 -0400 Subject: [PATCH] Properly fail results with rc != 0 Fixes #11769 --- lib/ansible/executor/task_executor.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/ansible/executor/task_executor.py b/lib/ansible/executor/task_executor.py index f9bc7cd2ed3..831680d30e5 100644 --- a/lib/ansible/executor/task_executor.py +++ b/lib/ansible/executor/task_executor.py @@ -327,9 +327,12 @@ class TaskExecutor: result['failed_when_result'] = result['failed'] = failed_when_result if failed_when_result: break - elif 'failed' not in result and result.get('rc', 0) == 0: - # if the result is not failed, stop trying - break + elif 'failed' not in result: + if result.get('rc', 0) != 0: + result['failed'] = True + else: + # if the result is not failed, stop trying + break if attempt < retries - 1: time.sleep(delay)