From 6b2bc9df04b66c67c42c67c19df96af9b47b0bde Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Thu, 17 Mar 2016 18:07:47 +0100 Subject: [PATCH] Fix #1809, use the proper method to fail --- system/firewalld.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/firewalld.py b/system/firewalld.py index 771d178d9d5..2ebd8b91555 100644 --- a/system/firewalld.py +++ b/system/firewalld.py @@ -260,7 +260,7 @@ def main(): supports_check_mode=True ) if module.params['source'] == None and module.params['permanent'] == None: - module.fail(msg='permanent is a required parameter') + module.fail_json(msg='permanent is a required parameter') if not HAS_FIREWALLD: module.fail_json(msg='firewalld and its python 2 module are required for this module')