Fix in pkgutil: don't call pipes.quote() on None.

In this function, 'site' may be None, which will cause an exception
if it is passed to pipes.quote().
pull/7776/head
Todd Owen 10 years ago
parent 3fb3e7e6dc
commit 247f70cf5c

@ -74,12 +74,10 @@ def package_installed(module, name):
def package_latest(module, name, site):
# Only supports one package
name = pipes.quote(name)
site = pipes.quote(site)
cmd = [ 'pkgutil', '--single', '-c' ]
if site is not None:
cmd += [ '-t', site ]
cmd.append(name)
cmd += [ '-t', pipes.quote(site) ]
cmd.append(pipes.quote(name))
cmd += [ '| tail -1 | grep -v SAME' ]
rc, out, err = module.run_command(' '.join(cmd), use_unsafe_shell=True)
if rc == 1:

Loading…
Cancel
Save