From 20936bbc3d811d37792535ac0b107b3b977a2242 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Tue, 22 Jan 2019 21:57:49 +0100 Subject: [PATCH] module mongodb_user fix roles default value (#46443) (#46526) * module mongodb_user fix roles default value (#46443) * mongodb_user remove ignoring test E324 * mongodb_user add changelog (#464443) * mongodb_user change doc to set parameter roles as None (#464443) * mongodb_user fix lint in changelog fragment (#464443) * mongodb_user : remove E325 exception in test --- .../fragments/46443-mongodb_user-fix-roles-default-value.yaml | 2 ++ lib/ansible/modules/database/mongodb/mongodb_user.py | 1 - test/sanity/validate-modules/ignore.txt | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/46443-mongodb_user-fix-roles-default-value.yaml diff --git a/changelogs/fragments/46443-mongodb_user-fix-roles-default-value.yaml b/changelogs/fragments/46443-mongodb_user-fix-roles-default-value.yaml new file mode 100644 index 00000000000..2feb2d04692 --- /dev/null +++ b/changelogs/fragments/46443-mongodb_user-fix-roles-default-value.yaml @@ -0,0 +1,2 @@ +minor_changes: +- mongodb_user - Change value for parameter roles to empty (https://github.com/ansible/ansible/issues/46443) diff --git a/lib/ansible/modules/database/mongodb/mongodb_user.py b/lib/ansible/modules/database/mongodb/mongodb_user.py index 6e6093ff8d8..f5634e98132 100644 --- a/lib/ansible/modules/database/mongodb/mongodb_user.py +++ b/lib/ansible/modules/database/mongodb/mongodb_user.py @@ -77,7 +77,6 @@ options: 'dbAdminAnyDatabase' - "Or the following dictionary '{ db: DATABASE_NAME, role: ROLE_NAME }'." - "This param requires pymongo 2.5+. If it is a string, mongodb 2.4+ is also required. If it is a dictionary, mongo 2.6+ is required." - default: "readWrite" state: description: - The database user state diff --git a/test/sanity/validate-modules/ignore.txt b/test/sanity/validate-modules/ignore.txt index 412dc5342e4..b19d2e36286 100644 --- a/test/sanity/validate-modules/ignore.txt +++ b/test/sanity/validate-modules/ignore.txt @@ -377,7 +377,6 @@ lib/ansible/modules/database/mongodb/mongodb_parameter.py E317 lib/ansible/modules/database/mongodb/mongodb_parameter.py E323 lib/ansible/modules/database/mongodb/mongodb_parameter.py E326 lib/ansible/modules/database/mongodb/mongodb_user.py E322 -lib/ansible/modules/database/mongodb/mongodb_user.py E324 lib/ansible/modules/database/mysql/mysql_replication.py E325 lib/ansible/modules/database/mysql/mysql_replication.py E326 lib/ansible/modules/database/mysql/mysql_user.py E322