From 1f3a3fdd3e565352cd4886dd6d31b376c86826b7 Mon Sep 17 00:00:00 2001 From: Jordan Borean Date: Mon, 22 Jul 2019 08:24:57 +1000 Subject: [PATCH] win_firewall_rule - removed deprecated force option (#59358) --- docs/docsite/rst/porting_guides/porting_guide_2.9.rst | 1 + lib/ansible/modules/windows/win_firewall_rule.ps1 | 5 ----- lib/ansible/modules/windows/win_firewall_rule.py | 7 ------- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/docs/docsite/rst/porting_guides/porting_guide_2.9.rst b/docs/docsite/rst/porting_guides/porting_guide_2.9.rst index 046af58d031..98a6e114d1b 100644 --- a/docs/docsite/rst/porting_guides/porting_guide_2.9.rst +++ b/docs/docsite/rst/porting_guides/porting_guide_2.9.rst @@ -140,6 +140,7 @@ Noteworthy module changes * The ``rds_snapshot_facts`` module was renamed to :ref:`rds_snapshot_info `. * The ``redshift_facts`` module was renamed to :ref:`redshift_info `. * The ``route53_facts`` module was renamed to :ref:`route53_info `. +* The deprecated ``force`` option in ``win_firewall_rule`` has been removed. Plugins diff --git a/lib/ansible/modules/windows/win_firewall_rule.ps1 b/lib/ansible/modules/windows/win_firewall_rule.ps1 index 5cee71e9989..3c4eb4de6ce 100644 --- a/lib/ansible/modules/windows/win_firewall_rule.ps1 +++ b/lib/ansible/modules/windows/win_firewall_rule.ps1 @@ -131,11 +131,6 @@ $security = Get-AnsibleParam -obj $params -name "security" -type "str" -validate $state = Get-AnsibleParam -obj $params -name "state" -type "str" -default "present" -validateset "present","absent" -$force = Get-AnsibleParam -obj $params -name "force" -type "bool" -default $false -if ($force) { - Add-DeprecationWarning -obj $result -message "'force' isn't required anymore" -version 2.9 -} - if ($diff_support) { $result.diff = @{} $result.diff.prepared = "" diff --git a/lib/ansible/modules/windows/win_firewall_rule.py b/lib/ansible/modules/windows/win_firewall_rule.py index 8ed9b6fdba2..ec74b1b6ed9 100644 --- a/lib/ansible/modules/windows/win_firewall_rule.py +++ b/lib/ansible/modules/windows/win_firewall_rule.py @@ -99,13 +99,6 @@ options: - Defaults to C(domain,private,public) when creating a new rule. type: list aliases: [ profile ] - force: - description: - - Replace any existing rule by removing it first. - - This is no longer required in Ansible 2.4 as rules no longer need replacing when being modified. - - DEPRECATED in Ansible 2.4 and will be removed in Ansible 2.9. - type: bool - default: no seealso: - module: win_firewall author: