Refactors bigip_node (#33492)

* Refactors bigip_node

Includes a number of fixes and enhancements in addition to refactoring
the code to be inline with f5 standards

* Fixes upstream errors

test/units/modules/network/f5/fixtures/load_ltm_node_1.json

@@ -0,0 +1,25 @@
+{
+  "kind": "tm:ltm:node:nodestate",
+  "name": "foo",
+  "partition": "Common",
+  "fullPath": "/Common/foo",
+  "generation": 158,
+  "selfLink": "https://localhost/mgmt/tm/ltm/node/~Common~foo?ver=13.0.0",
+  "address": "1.2.3.4",
+  "connectionLimit": 0,
+  "description": "my description of node",
+  "dynamicRatio": 1,
+  "ephemeral": "false",
+  "fqdn": {
+      "addressFamily": "ipv4",
+      "autopopulate": "disabled",
+      "downInterval": 5,
+      "interval": "3600"
+  },
+  "logging": "disabled",
+  "monitor": "default",
+  "rateLimit": "disabled",
+  "ratio": 1,
+  "session": "user-enabled",
+  "state": "unchecked"
+}

test/units/modules/network/f5/fixtures/load_ltm_node_3.json

@@ -0,0 +1,24 @@
+{
+  "kind": "tm:ltm:node:nodestate",
+  "name": "mytestserver",
+  "partition": "Common",
+  "fullPath": "/Common/mytestserver",
+  "generation": 2286,
+  "selfLink": "https://localhost/mgmt/tm/ltm/node/~Common~mytestserver?ver=13.0.0",
+  "address": "10.20.30.40",
+  "connectionLimit": 0,
+  "dynamicRatio": 1,
+  "ephemeral": "false",
+  "fqdn": {
+    "addressFamily": "ipv4",
+    "autopopulate": "disabled",
+    "downInterval": 5,
+    "interval": "3600"
+  },
+  "logging": "disabled",
+  "monitor": "/Common/icmp ",
+  "rateLimit": "disabled",
+  "ratio": 1,
+  "session": "monitor-enabled",
+  "state": "down"
+}

test/units/modules/network/f5/test_bigip_node.py

@@ -0,0 +1,143 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright (c) 2017 F5 Networks Inc.
+# GNU General Public License v3.0 (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+import os
+import json
+import sys
+
+from nose.plugins.skip import SkipTest
+if sys.version_info < (2, 7):
+    raise SkipTest("F5 Ansible modules require Python >= 2.7")
+
+from ansible.compat.tests import unittest
+from ansible.compat.tests.mock import Mock
+from ansible.compat.tests.mock import patch
+from ansible.module_utils.f5_utils import AnsibleF5Client
+
+try:
+    from library.bigip_node import Parameters
+    from library.bigip_node import ModuleManager
+    from library.bigip_node import ArgumentSpec
+    from ansible.module_utils.f5_utils import iControlUnexpectedHTTPError
+    from test.unit.modules.utils import set_module_args
+except ImportError:
+    try:
+        from ansible.modules.network.f5.bigip_node import Parameters
+        from ansible.modules.network.f5.bigip_node import ModuleManager
+        from ansible.modules.network.f5.bigip_node import ArgumentSpec
+        from ansible.module_utils.f5_utils import iControlUnexpectedHTTPError
+        from units.modules.utils import set_module_args
+    except ImportError:
+        raise SkipTest("F5 Ansible modules require the f5-sdk Python library")
+
+fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
+fixture_data = {}
+
+
+def load_fixture(name):
+    path = os.path.join(fixture_path, name)
+
+    if path in fixture_data:
+        return fixture_data[path]
+
+    with open(path) as f:
+        data = f.read()
+
+    try:
+        data = json.loads(data)
+    except Exception:
+        pass
+
+    fixture_data[path] = data
+    return data
+
+
+class TestParameters(unittest.TestCase):
+    def test_module_parameters(self):
+        args = dict(
+            host='10.20.30.40',
+            name='10.20.30.40'
+        )
+
+        p = Parameters(args)
+        assert p.host == '10.20.30.40'
+        assert p.name == '10.20.30.40'
+
+    def test_api_parameters(self):
+        args = load_fixture('load_ltm_node_1.json')
+
+        p = Parameters(args)
+        assert p.address == '1.2.3.4'
+
+
+@patch('ansible.module_utils.f5_utils.AnsibleF5Client._get_mgmt_root',
+       return_value=True)
+class TestManager(unittest.TestCase):
+
+    def setUp(self):
+        self.spec = ArgumentSpec()
+
+    def test_create_node(self, *args):
+        set_module_args(dict(
+            host='10.20.30.40',
+            name='mytestserver',
+            monitors=[
+                '/Common/icmp'
+            ],
+            partition='Common',
+            state='present',
+            password='passsword',
+            server='localhost',
+            user='admin'
+        ))
+
+        client = AnsibleF5Client(
+            argument_spec=self.spec.argument_spec,
+            supports_check_mode=self.spec.supports_check_mode,
+            f5_product_name=self.spec.f5_product_name
+        )
+        mm = ModuleManager(client)
+
+        # Override methods to force specific logic in the module to happen
+        mm.exists = Mock(side_effect=[False, True])
+        mm.create_on_device = Mock(return_value=True)
+
+        results = mm.exec_module()
+
+        assert results['changed'] is True
+
+    def test_create_selfip_idempotent(self, *args):
+        set_module_args(dict(
+            host='10.20.30.40',
+            name='mytestserver',
+            monitors=[
+                '/Common/icmp'
+            ],
+            partition='Common',
+            state='present',
+            password='passsword',
+            server='localhost',
+            user='admin'
+        ))
+
+        current = Parameters(load_fixture('load_ltm_node_3.json'))
+
+        client = AnsibleF5Client(
+            argument_spec=self.spec.argument_spec,
+            supports_check_mode=self.spec.supports_check_mode,
+            f5_product_name=self.spec.f5_product_name
+        )
+        mm = ModuleManager(client)
+
+        # Override methods to force specific logic in the module to happen
+        mm.exists = Mock(side_effect=[True, True])
+        mm.read_current_from_device = Mock(return_value=current)
+
+        results = mm.exec_module()
+
+        assert results['changed'] is False