From 1ef184ba2dcc6a90615fa52b70e2eb435054a42c Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Thu, 6 Jun 2024 13:59:26 -0700 Subject: [PATCH] [stable-2.16] Fix Test failure with cowsay installed/present (#83350) (cherry picked from commit e07b4edc547e2a5bd429d1027c0102235616db6c) Co-authored-by: MajesticMagikarpKing <69774548+yctomwang@users.noreply.github.com> --- changelogs/fragments/83327.yml | 3 +++ test/units/utils/display/test_broken_cowsay.py | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/83327.yml diff --git a/changelogs/fragments/83327.yml b/changelogs/fragments/83327.yml new file mode 100644 index 00000000000..8cdd448aa5d --- /dev/null +++ b/changelogs/fragments/83327.yml @@ -0,0 +1,3 @@ +--- +bugfixes: + - fixed unit test test_borken_cowsay to address mock not been properly applied when existing unix system already have cowsay installed. \ No newline at end of file diff --git a/test/units/utils/display/test_broken_cowsay.py b/test/units/utils/display/test_broken_cowsay.py index 96157e1a8b1..615fe5f418b 100644 --- a/test/units/utils/display/test_broken_cowsay.py +++ b/test/units/utils/display/test_broken_cowsay.py @@ -12,13 +12,12 @@ from unittest.mock import MagicMock def test_display_with_fake_cowsay_binary(capsys, mocker): - display = Display() mocker.patch("ansible.constants.ANSIBLE_COW_PATH", "./cowsay.sh") - mock_popen = MagicMock() mock_popen.return_value.returncode = 1 mocker.patch("subprocess.Popen", mock_popen) + display = Display() assert not hasattr(display, "cows_available") assert display.b_cowsay is None