From 1e619c44cde6d8267b95d382b6ad599d82b6fffa Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Sat, 20 Apr 2019 11:34:11 +0530 Subject: [PATCH] Remove redundant defined variable (#55122) Signed-off-by: Abhijeet Kasurde --- lib/ansible/module_utils/network/ftd/configuration.py | 2 -- lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py | 2 +- lib/ansible/modules/storage/netapp/na_ontap_volume.py | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/ansible/module_utils/network/ftd/configuration.py b/lib/ansible/module_utils/network/ftd/configuration.py index 2712467887f..4d92bdc0456 100644 --- a/lib/ansible/module_utils/network/ftd/configuration.py +++ b/lib/ansible/module_utils/network/ftd/configuration.py @@ -45,8 +45,6 @@ ADD_OPERATION_NOT_SUPPORTED_ERROR = ( PATH_PARAMS_FOR_DEFAULT_OBJ = {'objId': 'default'} -PATH_PARAMS_FOR_DEFAULT_OBJ = {'objId': 'default'} - class OperationNamePrefix: ADD = 'add' diff --git a/lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py b/lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py index 9157cb352b9..0a5d7859b14 100644 --- a/lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py +++ b/lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py @@ -169,7 +169,7 @@ def create_cpg( if not validate_set_size(raid_type, set_size): return (False, False, "Set size %s not part of RAID set %s" % (set_size, raid_type)) if not client_obj.cpgExists(cpg_name): - ld_layout = dict() + disk_patterns = [] if disk_type: disk_type = getattr(client.HPE3ParClient, disk_type) diff --git a/lib/ansible/modules/storage/netapp/na_ontap_volume.py b/lib/ansible/modules/storage/netapp/na_ontap_volume.py index 752c4f4a7dc..dbd8e6e76c9 100644 --- a/lib/ansible/modules/storage/netapp/na_ontap_volume.py +++ b/lib/ansible/modules/storage/netapp/na_ontap_volume.py @@ -890,7 +890,7 @@ class NetAppOntapVolume(object): return None self.module.fail_json(msg='Error fetching job info: %s' % to_native(error), exception=traceback.format_exc()) - results = dict() + job_info = result.get_child_by_name('attributes').get_child_by_name('job-info') results = { 'job-progress': job_info['job-progress'],