From 1d61f2a4fdceac950a35583c446b6a0a7bf61f4a Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Fri, 8 Nov 2024 03:56:51 +1300 Subject: [PATCH] remove ignore clauses for module uri (#83642) Co-authored-by: flowerysong --- changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml | 2 ++ lib/ansible/modules/uri.py | 1 + test/sanity/ignore.txt | 1 - 3 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml diff --git a/changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml b/changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml new file mode 100644 index 00000000000..14ff7a0723e --- /dev/null +++ b/changelogs/fragments/83642-fix-sanity-ignore-for-uri.yml @@ -0,0 +1,2 @@ +bugfixes: + - uri - mark ``url`` as required (https://github.com/ansible/ansible/pull/83642). diff --git a/lib/ansible/modules/uri.py b/lib/ansible/modules/uri.py index b19628b9aa2..78e431f5df0 100644 --- a/lib/ansible/modules/uri.py +++ b/lib/ansible/modules/uri.py @@ -605,6 +605,7 @@ def uri(module, url, dest, body, body_format, method, headers, socket_timeout, c def main(): argument_spec = url_argument_spec() + argument_spec['url']['required'] = True argument_spec.update( dest=dict(type='path'), url_username=dict(type='str', aliases=['user']), diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index 5736094ef8d..b3e83811373 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -25,7 +25,6 @@ lib/ansible/modules/service.py validate-modules:nonexistent-parameter-documented lib/ansible/modules/service.py validate-modules:use-run-command-not-popen lib/ansible/modules/stat.py validate-modules:parameter-invalid lib/ansible/modules/systemd_service.py validate-modules:parameter-invalid -lib/ansible/modules/uri.py validate-modules:doc-required-mismatch lib/ansible/modules/user.py validate-modules:doc-default-does-not-match-spec lib/ansible/modules/user.py validate-modules:use-run-command-not-popen lib/ansible/module_utils/basic.py pylint:unused-import # deferring resolution to allow enabling the rule now