From 1a8cdb5e3e68b710cec1c0b2d7d94f48d7f1586b Mon Sep 17 00:00:00 2001 From: Patrik Lundin Date: Thu, 28 Aug 2014 16:33:39 +0200 Subject: [PATCH] Check rc and print error message if any. It is probably good to use stdout before printing a generic error message as well. --- system/service.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/system/service.py b/system/service.py index e17eb610872..238612ea30a 100644 --- a/system/service.py +++ b/system/service.py @@ -992,8 +992,16 @@ class OpenBsdService(Service): if self.module.check_mode: self.module.exit_json(changed=True, msg="changing service enablement") - # XXX check rc ? rc, stdout, stderr = self.execute_command("%s %s" % (self.enable_cmd, action)) + + if rc != 0: + if stderr: + self.module.fail_json(msg=stderr) + elif stdout: + self.module.fail_json(msg=stdout) + else: + self.module.fail_json(msg="rcctl failed to modify service enablement") + self.changed = True # ===========================================