From 196f2f382b99ee4d668a4726ee7efcac88e8ce50 Mon Sep 17 00:00:00 2001 From: Ivan Bojer Date: Sat, 3 Feb 2018 03:35:17 -0800 Subject: [PATCH] removed panos_nat_policy (#34432) * removed panos_nat_policy * merge * removed extra line --- CHANGELOG.md | 2 +- docs/docsite/rst/porting_guide_2.5.rst | 1 + .../modules/network/panos/_panos_nat_policy.py | 15 +++++++-------- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cbf6bbb4ec1..05608cdf5e3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,7 +74,7 @@ See [Porting Guide](http://docs.ansible.com/ansible/devel/porting_guides.html) f * ec2_vpc. * ec2_ami_search, use ec2_ami_facts instead. * nxos_mtu, use nxos_system's `system_mtu` option. To specify an interfaces MTU use nxos_interface. - https://github.com/ansible/ansible/issues/29387 +* panos_nat_policy: Use panos_nat_rule the old module uses deprecated API calls ### New Plugins diff --git a/docs/docsite/rst/porting_guide_2.5.rst b/docs/docsite/rst/porting_guide_2.5.rst index d714295f9a9..869984e67e2 100644 --- a/docs/docsite/rst/porting_guide_2.5.rst +++ b/docs/docsite/rst/porting_guide_2.5.rst @@ -141,6 +141,7 @@ The following modules will be removed in Ansible 2.9. Please update update your * :ref:`nxos_portchannel ` use :ref:`nxos_linkagg ` instead. * :ref:`nxos_switchport ` use :ref:`nxos_l2_interface ` instead. * :ref:`panos_security_policy ` use :ref:`panos_security_rule ` instead. +* :ref:`panos_nat_policy ` use :ref:`panos_nat_rule ` instead. * :ref:`vsphere_guest ` use :ref:`vmware_guest ` instead. Noteworthy module changes diff --git a/lib/ansible/modules/network/panos/_panos_nat_policy.py b/lib/ansible/modules/network/panos/_panos_nat_policy.py index a476af0b962..7f7012383ea 100644 --- a/lib/ansible/modules/network/panos/_panos_nat_policy.py +++ b/lib/ansible/modules/network/panos/_panos_nat_policy.py @@ -19,6 +19,10 @@ # You should have received a copy of the GNU General Public License # along with Ansible. If not, see . +ANSIBLE_METADATA = {'metadata_version': '1.1', + 'status': ['deprecated'], + 'supported_by': 'community'} + DOCUMENTATION = ''' --- module: panos_nat_policy @@ -31,9 +35,9 @@ version_added: "2.3" requirements: - pan-python deprecated: - removed_in: "2.8" - why: M(panos_nat_rule) uses next generation SDK (PanDevice). - alternative: Use M(panos_nat_rule) instead. + alternative: Use M(panos_nat_rule) instead. + removed_in: '2.9' + why: This module depended on outdated and old SDK, use M(panos_nat_rule) instead. options: ip_address: description: @@ -145,11 +149,6 @@ RETURN = ''' # Default return values ''' -ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['deprecated'], - 'supported_by': 'community'} - - from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import get_exception