Add pep440 version_type for version test (#78308)

pull/78332/head
Matt Martz 2 years ago committed by GitHub
parent 9d4ced1237
commit 1429672213
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -0,0 +1,3 @@
minor_changes:
- Jinja version test - Add pep440 version_type for version test.
(https://github.com/ansible/ansible/issues/78288)

@ -169,7 +169,19 @@ As of Ansible 2.11 the ``version`` test accepts a ``version_type`` parameter whi
.. code-block:: console
loose, strict, semver, semantic
loose, strict, semver, semantic, pep440
``loose``
This type corresponds to the Python ``distutils.version.LooseVersion`` class. All version formats are valid for this type. The rules for comparison are simple and predictable, but may not always give expected results.
``strict``
This type corresponds to the Python ``distutils.version.StrictVersion`` class. A version number consists of two or three dot-separated numeric components, with an optional "pre-release" tag on the end. The pre-release tag consists of a single letter 'a' or 'b' followed by a number. If the numeric components of two version numbers are equal, then one with a pre-release tag will always be deemed earlier (lesser) than one without.
``semver``/``semantic``
This type implements the `Semantic Version <https://semver.org>`_ scheme for version comparison.
``pep440``
This type implements the Python `PEP-440 <https://peps.python.org/pep-0440/>`_ versioning rules for version comparison. Added in version 2.14.
Using ``version_type`` to compare a semantic version would be achieved like the following
@ -177,6 +189,12 @@ Using ``version_type`` to compare a semantic version would be achieved like the
{{ sample_semver_var is version('2.0.0-rc.1+build.123', 'lt', version_type='semver') }}
In Ansible 2.14, the ``pep440`` option for ``version_type`` was added, and the rules of this type are defined in `PEP-440 <https://peps.python.org/pep-0440/>`_. The following example showcases how this type can differentiate pre-releases as being less than a general release.
.. code-block:: yaml+jinja
{{ '2.14.0rc1' is version('2.14.0', 'lt', version_type='pep440') }}
When using ``version`` in a playbook or role, don't use ``{{ }}`` as described in the `FAQ <https://docs.ansible.com/ansible/latest/reference_appendices/faq.html#when-should-i-use-also-how-to-interpolate-variables-or-dynamic-variable-names>`_
.. code-block:: yaml

@ -32,6 +32,12 @@ from ansible.module_utils.parsing.convert_bool import boolean
from ansible.utils.display import Display
from ansible.utils.version import SemanticVersion
try:
from packaging.version import Version as PEP440Version
HAS_PACKAGING = True
except ImportError:
HAS_PACKAGING = False
display = Display()
@ -165,6 +171,7 @@ def version_compare(value, version, operator='eq', strict=None, version_type=Non
'strict': StrictVersion,
'semver': SemanticVersion,
'semantic': SemanticVersion,
'pep440': PEP440Version,
}
if strict is not None and version_type is not None:
@ -176,6 +183,9 @@ def version_compare(value, version, operator='eq', strict=None, version_type=Non
if not version:
raise errors.AnsibleFilterError("Version parameter to compare against cannot be empty")
if version_type == 'pep440' and not HAS_PACKAGING:
raise errors.AnsibleFilterError("The pep440 version_type requires the Python 'packaging' library")
Version = LooseVersion
if strict:
Version = StrictVersion

@ -0,0 +1,81 @@
DOCUMENTATION:
name: version
author: Ansible Core
version_added: "1.6"
short_description: compare version strings
description:
- Compare version strings using various versioning schemes
options:
_input:
description: Left hand version to compare
type: string
required: True
version:
description: Right hand version to compare
type: string
required: True
operator:
description: Comparison operator
type: string
required: False
choices:
- ==
- '='
- eq
- <
- lt
- <=
- le
- '>'
- gt
- '>='
- ge
- '!='
- <>
- ne
default: eq
strict:
description: Whether to use strict version scheme. Mutually exclusive with C(version_type)
type: boolean
required: False
default: False
version_type:
description: Version scheme to use for comparison. Mutually exclusive with C(strict). See C(notes) for descriptions on the version types.
type: string
required: False
choices:
- loose
- strict
- semver
- semantic
- pep440
default: loose
notes:
- C(loose) - This type corresponds to the Python C(distutils.version.LooseVersion) class. All version formats are valid for this type. The rules for comparison are simple and predictable, but may not always give expected results.
- C(strict) - This type corresponds to the Python C(distutils.version.StrictVersion) class. A version number consists of two or three dot-separated numeric components, with an optional "pre-release" tag on the end. The pre-release tag consists of a single letter C(a) or C(b) followed by a number. If the numeric components of two version numbers are equal, then one with a pre-release tag will always be deemed earlier (lesser) than one without.
- C(semver)/C(semantic) - This type implements the L(Semantic Version,https://semver.org) scheme for version comparison.
- C(pep440) - This type implements the Python L(PEP-440,https://peps.python.org/pep-0440/) versioning rules for version comparison. Added in version 2.14.
EXAMPLES: |
- name: version test examples
assert:
that:
- "'1.0' is version_compare('1.0', '==')" # old name
- "'1.0' is version('1.0', '==')"
- "'1.0' is version('2.0', '!=')"
- "'1.0' is version('2.0', '<')"
- "'2.0' is version('1.0', '>')"
- "'1.0' is version('1.0', '<=')"
- "'1.0' is version('1.0', '>=')"
- "'1.0' is version_compare('1.0', '==', strict=true)" # old name
- "'1.0' is version('1.0', '==', strict=true)"
- "'1.0' is version('2.0', '!=', strict=true)"
- "'1.0' is version('2.0', '<', strict=true)"
- "'2.0' is version('1.0', '>', strict=true)"
- "'1.0' is version('1.0', '<=', strict=true)"
- "'1.0' is version('1.0', '>=', strict=true)"
- "'1.2.3' is version('2.0.0', 'lt', version_type='semver')"
- "'2.14.0rc1' is version('2.14.0', 'lt', version_type='pep440')"
RETURN:
_value:
description: Returns C(True) or C(False) depending on the outcome of the comparison.
type: boolean

@ -271,6 +271,7 @@
- "'1.0' is version('1.0', '<=', true)"
- "'1.0' is version('1.0', '>=', true)"
- "'1.2.3' is version('2.0.0', 'lt', version_type='semver')"
- "'2.14.0rc1' is version('2.14.0', 'lt', version_type='pep440')"
- version_bad_operator is failed
- version_bad_value is failed
- version_strict_version_type is failed

Loading…
Cancel
Save