Fixes #24241 Module always updates installed plugins (#40645)

* Update jenkins_plugin.py

When setting state=latest, plugin are always updated because old sha1 is bytes and and is compared to new sha1 which is str (so it always detecting a sha1 change)

* Add changelog
pull/40788/head
Benoit Dunand-Laisin 8 years ago committed by Sam Doran
parent 7ffbdd5214
commit 116a504825

@ -0,0 +1,2 @@
bugfixes:
- jenkins_plugin: fix plugin always updated even if already uptodate (https://github.com/ansible/ansible/pull/40645)

@ -275,7 +275,7 @@ state:
sample: "present"
'''
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.basic import AnsibleModule, to_bytes
from ansible.module_utils.six.moves.urllib.parse import urlencode
from ansible.module_utils.urls import fetch_url, url_argument_spec
from ansible.module_utils._text import to_native
@ -505,7 +505,7 @@ class JenkinsPlugin(object):
sha1sum_old = base64.b64encode(sha1_old.digest())
# If the latest version changed, download it
if sha1sum_old != plugin_data['sha1']:
if sha1sum_old != to_bytes(plugin_data['sha1']):
if not self.module.check_mode:
r = self._download_plugin(plugin_url)
self._write_file(plugin_file, r)

Loading…
Cancel
Save