From 10f9b8e6554e024e3561170153b8e7fde5e7e4fb Mon Sep 17 00:00:00 2001 From: Eric Appelt Date: Tue, 21 May 2024 10:14:29 -0500 Subject: [PATCH] Correct code comment in PBE to reflect current behavior (#83269) Correct a code comment in the PlaybookExecutor class that explains the host failure condition under which the PBE breaks out of the run. This comment previously stated that the maximum failure percentage was checked, but that logic has been refactored into the linear strategy plugin. --- lib/ansible/executor/playbook_executor.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/ansible/executor/playbook_executor.py b/lib/ansible/executor/playbook_executor.py index 7c3ac4113bf..f439967838b 100644 --- a/lib/ansible/executor/playbook_executor.py +++ b/lib/ansible/executor/playbook_executor.py @@ -195,10 +195,7 @@ class PlaybookExecutor: result = self._tqm.RUN_FAILED_HOSTS break_play = True - # check the number of failures here, to see if they're above the maximum - # failure percentage allowed, or if any errors are fatal. If either of those - # conditions are met, we break out, otherwise we only break out if the entire - # batch failed + # check the number of failures here and break out if the entire batch failed failed_hosts_count = len(self._tqm._failed_hosts) + len(self._tqm._unreachable_hosts) - \ (previously_failed + previously_unreachable)