From 0f3480d35907f21737b3459abce90f60fa9542e6 Mon Sep 17 00:00:00 2001 From: Alberto Murillo Date: Wed, 25 Apr 2018 11:58:29 -0500 Subject: [PATCH] docker_image: Fix idempotency of pull (#31956) when pulling an image with force=yes the task was marked as changed everytime even when the image hasn't changed. This was due to a bad comparison of the image tag before the pull and after the pull. Fixes #22596 Signed-off-by: Alberto Murillo --- lib/ansible/modules/cloud/docker/docker_image.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/cloud/docker/docker_image.py b/lib/ansible/modules/cloud/docker/docker_image.py index a1a9ae8012c..7d497fb901c 100644 --- a/lib/ansible/modules/cloud/docker/docker_image.py +++ b/lib/ansible/modules/cloud/docker/docker_image.py @@ -336,8 +336,8 @@ class ImageManager(DockerBaseClass): self.results['actions'].append('Pulled image %s:%s' % (self.name, self.tag)) self.results['changed'] = True if not self.check_mode: - self.results['image'] = self.client.pull_image(self.name, tag=self.tag) - if image and image == self.results['image']: + self.results['image'], already_latest = self.client.pull_image(self.name, tag=self.tag) + if already_latest: self.results['changed'] = False if self.archive_path: