Woops, make collect/delete loop more efficient.

10 years ago · 0d0205ad54
parent 047bd6f651
commit 0d0205ad54
1 changed files with 3 additions and 3 deletions
--- a/cloud/amazon/ec2_asg.py
+++ b/cloud/amazon/ec2_asg.py
@ -363,15 +363,15 @@ def create_autoscaling_group(connection, module):
            for tag in asg_tags:
                want_tags[tag.key] = [tag.value, tag.propagate_at_launch]

+            dead_tags = []
            for tag in as_group.tags:
                have_tags[tag.key] = [tag.value, tag.propagate_at_launch]
-                dead_tags = []
                if not tag.key in want_tags:
                    changed = True
                    dead_tags.append(tag)

-                if dead_tags != []:
-                    connection.delete_tags(dead_tags)
+            if dead_tags != []:
+                connection.delete_tags(dead_tags)

            if have_tags != want_tags:
                changed = True