ansible/changelogs/fragments/72992-user-account-lock-alw...

bugfixes:
  - >
    user - do the right thing when ``password_lock=True`` and ``password``
    are used together (https://github.com/ansible/ansible/issues/72992)
[stable-2.10] user - properly handle password and password lock when used together (#73016) (#73177) Do the right thing on Linux when password lock and a password hash are provided by writing out the password hash prepended by the appropriate lock string rather than using -U and -L. This is the correct way to set and lock the account in one command. On BSD, run separate commands as appropriate since locking and setting the password cannot be done in a single action. FreeBSD requires running several commands to get the account in the desired state. As a result, the rc, output, and error from all commands need to be combined and evaluated so an accurate and complete summary can be given at the end of module execution. * Improve integration tests to cover this scenario. * Break up user integration tests into smaller files * Properly lock account when creating a new account and password is supplied * Simplify rc collection in FreeBSD class Since the _handle_lock() method was added, the rc would be set to None, which could make task change reporting incorrect. My first attempt to solve this used a set and was a bit too complicated. Simplify it my comparing the rc from _handle_lock() and the current value of rc. * Improve the Linux password hash and locking behavior If password lock and hash are provided, set the hash and lock the account by using a password hash since -L cannot be used with -p. * Ensure -U and -L are not combined with -p since they are mutually exclusive to usermod. * Clarify password_lock behavior.. (cherry picked from commit 264e08f21a15213a4db76339888d3dfa2f2d6abb) Co-authored-by: Sam Doran <sdoran@redhat.com> 4 years ago			`bugfixes:`
			`- >`
			user - do the right thing when ``password_lock=True`` and ``password``
			`are used together (https://github.com/ansible/ansible/issues/72992)`